This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
amo be gone (bug 1042820) #2827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -334,8 +334,8 @@ class DELETE_REVIEW(_LOG): | |||
| """Requires review.id and add-on objects.""" | |||
There was a problem hiding this comment.
I will tidy log.py after, promise 😄
|
Can you rebase so tests can run? |
eviljeff
force-pushed
the
amo-be-gone
branch
3 times, most recently
from
864b355
to
a57a007
Compare
|
|
| LOG_HIDE_DEVELOPER, LOG_KEEP, LOG_REVIEW_QUEUE, | ||
| LOG_REVIEW_EMAIL_USER, log) | ||
|
|
||
| logger_log = commonware.log.getLogger('z.amo') |
|
r+wc. This looks good. Let's merge early so we can get a week of testing on this on -dev. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Touch all the files!
note: this was a find/replace so there will probably be some messy import lines. Tests pass and it (trivially) runs though.