This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
add reply tokens in reviewer emails (Bug 879535) #898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Include Mozilla contact. | ||
| if thread.read_permission_mozilla_contact: | ||
| if thread.addon.mozilla_contact: | ||
| recipients.append(thread.addon.mozilla_contact) |
There was a problem hiding this comment.
this should be [x.split() for x in thread.addon.mozilla_contact.split(',')], right?
|
looks good; let me know when these things are addressed |
| {% block content %} | ||
| {% trans -%} | ||
| A user posted on a discussion of {{ name }} | ||
|
|
There was a problem hiding this comment.
when you use a {% trans %} tag all the whitespace (i.e., newlines) gets collapsed ;)
There was a problem hiding this comment.
I was inspired by this
There was a problem hiding this comment.
Can something like {% blocktrans %} be used here ?
|
fix those things and this looks good to merge |
| emails, perm_setting='app_reviewed', cc=cc_email, | ||
| attachments=self.get_attachments()) | ||
|
|
||
| if self.comm_thread and waffle.switch_is_active('comm_emails'): |
There was a problem hiding this comment.
waffle name = 'comm-dashboard' :/
|
r+wc |
| @@ -0,0 +1,8 @@ | |||
| {% extends 'reviewers/emails/base.txt' -%} | |||
| {% block content %} | |||
| {{ _('A user posted on a discussion of {0}.', name) }} | |||
There was a problem hiding this comment.
{{ _('A user posted on a discussion of {name}.')|f(name=name) }}
There was a problem hiding this comment.
This could probably use an L10n comment.
| thread=self.thread, note_type=0, body='something', | ||
| read_permission_developer=True) | ||
| res = self.client.post(reverse('comm-note-replies-list', | ||
| kwargs={'thread_id': self.thread.id, |
|
r+wc |
|
merged 600e47 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.