Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget doesn't return results for DOIs with extra stashes. #135

Open
rcpeters opened this issue Sep 27, 2015 · 12 comments
Open

Widget doesn't return results for DOIs with extra stashes. #135

rcpeters opened this issue Sep 27, 2015 · 12 comments

Comments

@rcpeters
Copy link
Member

The widget returns badges for doi 10.1186/2047-217X-3-13
https://badges.mozillascience.org/papers/10.1186/2047-217X-3-13/badges
However the widget doesn't return badges for 10.1093/nar/gkt1063
https://badges.mozillascience.org/papers/10.1093/nar/gkt1063/badges I'm guess this has to do with the second slash of the doi.

@abbycabs
Copy link
Member

You need to encode the 2nd half of the doi
https://badges.mozillascience.org/papers/10.1093/nar%2Fgkt1063/badges

@rcpeters
Copy link
Member Author

Hum...I would expect the javascript widget to do if we are trying to make the widget as easy as possible to use. Also the DIO is a value. Not encoding one half of a value and encoding the other half doesn't make a whole lot of sense.

@abbycabs
Copy link
Member

+1 good points

@Alicole
Copy link
Contributor

Alicole commented Sep 29, 2015

@rcpeters, @acabunoc -- Quite frankly the widget treats the doi as a string, you could put any number of slashes in it and it will still create an endpoint string. It also does this with the updated code, yet to be committed.

Have you tried: https://badges.mozillascience.org/papers/10.1093/nar/gkt1063/badges

This yields: "Page not found"

Does this article have any badges?

@abbycabs
Copy link
Member

@Alicole -
This is the correct link, there are badges:
https://badges.mozillascience.org/papers/10.1093/nar%2Fgkt1063/badges

I think we can handle this on the app side for usability :)

@Alicole
Copy link
Contributor

Alicole commented Sep 29, 2015

@acabunoc -- Thanks for that -- yes when you use the url encoding character for / %2F it works.

Agreed -- for usability it'll probably be better if you can find a way to make this work at your end.

@abbycabs abbycabs mentioned this issue Nov 25, 2015
janhohner added a commit to janhohner/PaperBadger that referenced this issue Dec 19, 2015
New widget with different display options (see docs/widger.js) and demos (in public/widgets/demos). Also provides solutions for mozillascience#142 (loading spinner) and mozillascience#135 (DOIs with extra slashes)
@janhohner janhohner mentioned this issue Dec 19, 2015
@abbycabs
Copy link
Member

While this is address in /widget.js, I'll keep this open since I'd like to fix this on the app side

@Alicole
Copy link
Contributor

Alicole commented Jun 3, 2016

@acabunoc -- in terms of the url with %2F -- is this something that you've look at? Or is it still outstanding? Do you know if this has posed any issues with the wider community?

@abbycabs
Copy link
Member

abbycabs commented Jun 3, 2016

Hey @Alicole! i haven't had a chance to look at it -- still outstanding!

It's pretty rare, but does affect the wider community. I'm still at #mozsprint, this might be a good task for today!

@Alicole
Copy link
Contributor

Alicole commented Jun 3, 2016

@acabunoc -- Thanks it would be great if this was closed soon, as it would help prevent any issues with url path inconsistencies.

@abbycabs
Copy link
Member

abbycabs commented Jun 3, 2016

@Alicole I'll make this a priority!

@josmas
Copy link
Member

josmas commented Oct 27, 2016

on review #212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants