New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复 pinyin 函数的 strict 参数的默认值无意中被修改为了 False #121

Merged
merged 1 commit into from Feb 3, 2018

Conversation

Projects
None yet
3 participants
@mozillazg
Owner

mozillazg commented Feb 3, 2018

PR 描述

修复 pinyin 函数的 strict 参数的默认值无意中被修改为了 False,恢复为预期的 True

待办事项

  • 符合代码规范
  • 单元测试
  • 文档

@mozillazg mozillazg self-assigned this Feb 3, 2018

@mozillazg mozillazg added the bug label Feb 3, 2018

@mozillazg mozillazg added this to the 0.30.0 milestone Feb 3, 2018

@codecov

This comment has been minimized.

codecov bot commented Feb 3, 2018

Codecov Report

Merging #121 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #121   +/-   ##
========================================
  Coverage    99.24%   99.24%           
========================================
  Files           20       20           
  Lines          530      530           
========================================
  Hits           526      526           
  Misses           4        4
Impacted Files Coverage Δ
pypinyin/core.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddfdf19...49fdf06. Read the comment docs.

@coveralls

This comment has been minimized.

coveralls commented Feb 3, 2018

Coverage Status

Coverage remained the same at 99.245% when pulling 49fdf06 on fix-pinyin-strict into ddfdf19 on develop.

4 similar comments
@coveralls

This comment has been minimized.

coveralls commented Feb 3, 2018

Coverage Status

Coverage remained the same at 99.245% when pulling 49fdf06 on fix-pinyin-strict into ddfdf19 on develop.

@coveralls

This comment has been minimized.

coveralls commented Feb 3, 2018

Coverage Status

Coverage remained the same at 99.245% when pulling 49fdf06 on fix-pinyin-strict into ddfdf19 on develop.

@coveralls

This comment has been minimized.

coveralls commented Feb 3, 2018

Coverage Status

Coverage remained the same at 99.245% when pulling 49fdf06 on fix-pinyin-strict into ddfdf19 on develop.

@coveralls

This comment has been minimized.

coveralls commented Feb 3, 2018

Coverage Status

Coverage remained the same at 99.245% when pulling 49fdf06 on fix-pinyin-strict into ddfdf19 on develop.

@mozillazg

This comment has been minimized.

Owner

mozillazg commented Feb 3, 2018

@bors-homu

This comment has been minimized.

Collaborator

bors-homu commented Feb 3, 2018

📌 Commit 49fdf06 has been approved by mozillazg

bors-homu added a commit that referenced this pull request Feb 3, 2018

Auto merge of #121 - mozillazg:fix-pinyin-strict, r=mozillazg
修复 pinyin 函数的 strict 参数的默认值无意中被修改为了 False

## PR 描述

修复 `pinyin` 函数的 `strict` 参数的默认值无意中被修改为了 `False`,先恢复为预期的 `True`。

## 待办事项

* [x] 符合代码规范
* [x] 单元测试
* [x] 文档

<!--
感谢你的贡献!❤️
-->
@bors-homu

This comment has been minimized.

Collaborator

bors-homu commented Feb 3, 2018

⌛️ Testing commit 49fdf06 with merge 7e5c981...

@bors-homu

This comment has been minimized.

Collaborator

bors-homu commented Feb 3, 2018

☀️ Test successful - status-travis
Approved by: mozillazg
Pushing 7e5c981 to develop...

@bors-homu bors-homu merged commit 49fdf06 into develop Feb 3, 2018

6 checks passed

codecov/patch Coverage not affected when comparing ddfdf19...49fdf06
Details
codecov/project 99.24% remains the same compared to ddfdf19
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.245%
Details
homu Test successful
Details

@mozillazg mozillazg deleted the fix-pinyin-strict branch Feb 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment