New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修复 pinyin 函数的 strict 参数的默认值无意中被修改为了 False #121

Merged

bors-homu merged 1 commit into develop from fix-pinyin-strict

Feb 3, 2018

Owner

mozillazg commented Feb 3, 2018 •

edited

Loading

PR 描述

修复 pinyin 函数的 strict 参数的默认值无意中被修改为了 False，恢复为预期的 True。

待办事项

符合代码规范
单元测试
文档


          修复 pinyin 函数的 strict 参数的默认值无意中被修改为了 False

49fdf06

mozillazg self-assigned this

mozillazg added the bug label

mozillazg added this to the 0.30.0 milestone

codecov bot commented Feb 3, 2018 •

edited

Loading

Codecov Report

Merging #121 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #121   +/-   ##
========================================
  Coverage    99.24%   99.24%           
========================================
  Files           20       20           
  Lines          530      530           
========================================
  Hits           526      526           
  Misses           4        4

Impacted Files	Coverage Δ
pypinyin/core.py	`100% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddfdf19...49fdf06. Read the comment docs.

coveralls commented Feb 3, 2018

Coverage remained the same at 99.245% when pulling 49fdf06 on fix-pinyin-strict into ddfdf19 on develop.

4 similar comments

coveralls commented Feb 3, 2018

Coverage remained the same at 99.245% when pulling 49fdf06 on fix-pinyin-strict into ddfdf19 on develop.

coveralls commented Feb 3, 2018

Coverage remained the same at 99.245% when pulling 49fdf06 on fix-pinyin-strict into ddfdf19 on develop.

coveralls commented Feb 3, 2018

Coverage remained the same at 99.245% when pulling 49fdf06 on fix-pinyin-strict into ddfdf19 on develop.

coveralls commented Feb 3, 2018 •

edited

Loading

Coverage remained the same at 99.245% when pulling 49fdf06 on fix-pinyin-strict into ddfdf19 on develop.

Owner Author

mozillazg commented Feb 3, 2018

Collaborator

bors-homu commented Feb 3, 2018

📌 Commit 49fdf06 has been approved by mozillazg

bors-homu added a commit that referenced this pull request


          Auto merge of #121 - mozillazg:fix-pinyin-strict, r=mozillazg

7e5c981

修复 pinyin 函数的 strict 参数的默认值无意中被修改为了 False

## PR 描述

修复 `pinyin` 函数的 `strict` 参数的默认值无意中被修改为了 `False`，先恢复为预期的 `True`。

## 待办事项

* [x] 符合代码规范
* [x] 单元测试
* [x] 文档

<!--
感谢你的贡献！❤️
-->

Collaborator

bors-homu commented Feb 3, 2018

⌛ Testing commit 49fdf06 with merge 7e5c981...

Collaborator

bors-homu commented Feb 3, 2018

☀️ Test successful - status-travis
Approved by: mozillazg
Pushing 7e5c981 to develop...

bors-homu merged commit 49fdf06 into develop

mozillazg deleted the fix-pinyin-strict branch

February 3, 2018 02:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug