Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix bug 1371258] Filter snippets based on vertical screen resolution. #236

Merged
merged 1 commit into from Jun 13, 2017
Merged

[fix bug 1371258] Filter snippets based on vertical screen resolution. #236

merged 1 commit into from Jun 13, 2017

Conversation

glogiotatidis
Copy link
Contributor

@glogiotatidis glogiotatidis commented Jun 12, 2017 •
edited

Adds client size filtering code and the django admin UI interface to filter snippets based on predefined resolutions.

screenshot-2017-6-12 change snippet mozilla snippets 2

@glogiotatidis glogiotatidis requested a review from pmac June 12, 2017 08:09
pmac
pmac approved these changes Jun 12, 2017
View reviewed changes
Copy link
Member

@pmac pmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tested it locally, but the code changes look good to me. Nice work 👍

@glogiotatidis glogiotatidis merged commit 0081d74 into mozmeao:master Jun 13, 2017
@glogiotatidis glogiotatidis deleted the resolution branch April 16, 2018 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmac pmac pmac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glogiotatidis @pmac