block AWS cronjob #803
Merged
block AWS cronjob #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jgmize
reviewed
Apr 23, 2018
k8s/tools/block-aws/Dockerfile
Outdated
| @@ -0,0 +1,27 @@ | |||
| FROM python:2-slim | |||
There was a problem hiding this comment.
Have you tried this with python 3?
There was a problem hiding this comment.
it was supposed to be python3! Great catch!
|
updated to python 3, currently running in Oregon-A. |
jgmize
reviewed
Apr 24, 2018
k8s/tools/block-aws/build.sh
Outdated
| @@ -0,0 +1,5 @@ | |||
| GIT_COMMIT_RAW=$(git rev-parse HEAD) | |||
| GIT_COMMIT=${GIT_COMMIT_RAW:0:7} | |||
There was a problem hiding this comment.
This can be simplified to
GIT_COMMIT=$(git rev-parse --short HEAD)
jgmize
reviewed
Apr 24, 2018
k8s/tools/block-aws/build.sh
Outdated
| GIT_COMMIT_RAW=$(git rev-parse HEAD) | ||
| GIT_COMMIT=${GIT_COMMIT_RAW:0:7} | ||
|
|
||
| docker build . -t quay.io/mozmar/blockaws:${GIT_COMMIT} |
There was a problem hiding this comment.
You could also eliminate the GIT_COMMIT definition above entirely and declare and assign a default on the first use:
docker build . -t quay.io/mozmar/blockaws:${GIT_COMMIT:=$(git rev-parse --short HEAD)}
This has the added benefit of allowing it to be overridden with an environment variable.
|
TODO: add DMS + secret |
jgmize
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.