Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make snippet localization easier #997

Closed
glogiotatidis opened this issue May 14, 2019 · 1 comment
Closed

Make snippet localization easier #997

glogiotatidis opened this issue May 14, 2019 · 1 comment
Assignees
@glogiotatidis
Labels
👑 Admin Related to the interface used to manage snippets. 🌄 PR Has Pull Request

Comments

@glogiotatidis
Copy link
Contributor

Original bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=870491

Althought I don't believe we will support in app localization anytime soon, we have make things easier by setting the default values on fields like the block button #757

Let's explore options.
@triage-new-issues triage-new-issues bot added Triage and removed Triage labels May 14, 2019
@glogiotatidis glogiotatidis added the 👑 Admin Related to the interface used to manage snippets. label May 22, 2019
glogiotatidis added a commit to glogiotatidis/snippets-service that referenced this issue Jun 20, 2019
@glogiotatidis
[Issue mozmeao#997] Migrate TargetedLocales to Locale
938fe9c
glogiotatidis added a commit to glogiotatidis/snippets-service that referenced this issue Jun 20, 2019
@glogiotatidis
[Issue mozmeao#997] Migrate TargetedLocales to Locale
484e950
glogiotatidis added a commit to glogiotatidis/snippets-service that referenced this issue Jun 20, 2019
@glogiotatidis
[Issue mozmeao#997] Migrate TargetedLocales to Locale
7db16b7
glogiotatidis added a commit to glogiotatidis/snippets-service that referenced this issue Jun 20, 2019
@glogiotatidis
[Issue mozmeao#997] Migrate TargetedLocales to Locale
33b6347
glogiotatidis added a commit to glogiotatidis/snippets-service that referenced this issue Jun 20, 2019
@glogiotatidis
[Issue mozmeao#997] Migrate TargetedLocales to Locale
857af9f
glogiotatidis added a commit to glogiotatidis/snippets-service that referenced this issue Jun 20, 2019
@glogiotatidis
[Issue mozmeao#997] Migrate TargetedLocales to Locale
82777da
glogiotatidis added a commit to glogiotatidis/snippets-service that referenced this issue Jun 20, 2019
@glogiotatidis
[Issue mozmeao#997] Migrate TargetedLocales to Locale
b98ff8b
@glogiotatidis glogiotatidis self-assigned this Jun 20, 2019
@glogiotatidis glogiotatidis added the 🌄 PR Has Pull Request label Jun 20, 2019
jpetto added a commit that referenced this issue Jun 25, 2019
@jpetto
Merge pull request #1045 from glogiotatidis/new-locales
ebc18f3 
[Issue #997] Migrate TargetedLocales to Locale
@glogiotatidis glogiotatidis removed this from Review in MozMEAO backend/infra Jun 27, 2019
@glogiotatidis
Copy link
Contributor Author

This is done. Will work on #757 to add more localized strings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glogiotatidis glogiotatidis

Labels
👑 Admin Related to the interface used to manage snippets. 🌄 PR Has Pull Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glogiotatidis