Call DOM altering functions after snippet finishes initializing. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Add sample rate and snippet ID to currently displayed links. | ||
| var parameters = ('sample_rate=' + SNIPPET_METRICS_SAMPLE_RATE + '&snippet_name=' + | ||
| show_snippet_id); | ||
| modifyLinks(topSection.getElementsByTagName('a'), parameters); |
There was a problem hiding this comment.
seeing we know we will always be in Fx only, I would do:
...(topSection.querySelectorAll('a'),....
There was a problem hiding this comment.
is querySelectorAll a Fx only feature? Is this faster?
There was a problem hiding this comment.
No, not Fx only, all modern browsers support it and yes, unless you are doing getElementById it is faster.
glogiotatidis
force-pushed
the
alter-after-init
branch
from
74d999e
to
813acac
Compare
|
@schalkneethling do you have any other comments on this? Reading your comments on mozmeao/snippets#53 if you can use the close button on the logo it means that this works as expected for you. |
|
r+ 🀄 |
|
I do not have big green button access so, merge at will. |
|
Thanks! |
glogiotatidis
added a commit
that referenced
this pull request
Sep 8, 2015
Call DOM altering functions after snippet finishes initializing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.