APIとテストに変更がなければ、常に同じドキュメントを生成できるようにしたい(訂正版 #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更に誤りがあったので、いったん閉じさせていただいた以下のpull requestに書いていた通りです。
#20
Test::JsonAPI::Autodoc::Responseのjsonの生成部分にcanonicalを指定しました。以下の箇所です。
https://github.com/moznion/Test-JsonAPI-Autodoc/blob/master/lib/Test/JsonAPI/Autodoc/Response.pm#L20
50回同じドキュメントを生成してみて、すべて中身が同じであったか確認するテストも作成しました。
仮に今回の修正部分が壊れても、稀にテストが通ってしまうこともある(たまたま50回連続で同じ要素順でjsonが生成された場合)のですが、性質上仕方がないかなと思っています。
何もテストないよりはましかなと.....