Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Better field type detection, fixes #250 #251

Merged
merged 1 commit into from
Nov 15, 2020

Conversation

elektro-wolle
Copy link
Contributor

Make sure that:

  • You have read the contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Performance is slightly worse, especially for Doubles.

Current code:

GelfMessageBenchmark.discoverDoubleField                     avgt    5     34,866 ±   4,471  ns/op
GelfMessageBenchmark.discoverLongField                       avgt    5     15,418 ±   2,406  ns/op
GelfMessageBenchmark.discoverStringField                     avgt    5      5,405 ±   1,440  ns/op

New code:

GelfMessageBenchmark.discoverDoubleField  avgt    5  235,740 ± 5,143  ns/op
GelfMessageBenchmark.discoverLongField    avgt    5   26,484 ± 1,803  ns/op
GelfMessageBenchmark.discoverStringField  avgt    5    5,242 ± 0,254  ns/op

@mp911de mp911de merged commit 07b687e into mp911de:main Nov 15, 2020
mp911de added a commit that referenced this pull request Nov 15, 2020
Original pull request: #251.
@mp911de
Copy link
Owner

mp911de commented Nov 15, 2020

Thank you for your contribution. That's merged and polished now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants