Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Sender specific configurations on sender factory #34

Closed
wants to merge 1 commit into from

Conversation

Batigoal
Copy link
Contributor

Added the possibility for sender specific (sender) configurations on sender factory .
Cause: Sometimes very (company) specific sender specifications are needed, which cannot be configured system-wide. Now its possible to inject them, by overriding or wrapping the original Logging-IMplementations.

@@ -168,6 +173,7 @@
public class GelfLogAppender extends AbstractAppender implements ErrorReporter {
private static final Logger LOGGER = StatusLogger.getLogger();

protected Map<String,Object> senderSpecificProperties = new HashMap<String,Object>();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field is not used.

@mp911de
Copy link
Owner

mp911de commented Oct 18, 2014

Thanks for your PR. Can you take a look at the minor issues? I'll merge it manually (or you fetch the latest commits and reapply your changes, so I can let Github do the merge) then.

@Batigoal
Copy link
Contributor Author

If you can merge it manuall I would be grateful. Otherwise I can fetch, merge and commit on tuesday

mp911de pushed a commit that referenced this pull request Oct 18, 2014
@mp911de
Copy link
Owner

mp911de commented Oct 18, 2014

Merged manually.

@mp911de mp911de closed this Oct 18, 2014
@Batigoal
Copy link
Contributor Author

Thank you very much!
Is it possible to release in the near future?
I would need a release for my maven project.

Thank you very much

@mp911de
Copy link
Owner

mp911de commented Oct 23, 2014

Hi,
I’ll release the code tomorrow.

Best regards, Mark

Am 23.10.2014 um 10:49 schrieb Batigoal notifications@github.com:

Thank you very much!
Is it possible to release in the near future?
I would need a release for my maven project.

Thank you very much


Reply to this email directly or view it on GitHub #34 (comment).

@mp911de
Copy link
Owner

mp911de commented Oct 24, 2014

Pushed artifacts to mvn central, Should become available within the next hours.

Am 23.10.2014 um 20:37 schrieb Mark Paluch mpaluch@paluch.biz:

Hi,
I’ll release the code tomorrow.

Best regards, Mark

Am 23.10.2014 um 10:49 schrieb Batigoal <notifications@github.com mailto:notifications@github.com>:

Thank you very much!
Is it possible to release in the near future?
I would need a release for my maven project.

Thank you very much


Reply to this email directly or view it on GitHub #34 (comment).

@Batigoal
Copy link
Contributor Author

Thanks!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants