Fix hostname parsing when no port is provided

mpalmer · Jul 22, 2011 · aa4462c · aa4462c
1 parent ed0930d
commit aa4462c
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/http/modules/ngx_http_ssl_module.c b/src/http/modules/ngx_http_ssl_module.c
@@ -656,20 +656,23 @@ ngx_http_ssl_session_cache(ngx_conf_t *cf, ngx_command_t *cmd, void *conf)
                 /* We have a host */
                 len = 0;
                 for (j = total_len; j < value[i].len; j++) {
-                    total_len++;
                     if (value[i].data[j] == ':') {
                         value[i].data[j] = '\0';
                         break;
                     }
+                    total_len++;
                     len++;
                 }
 
                 sscf->ext_session_cache.memcache_host.len = len;
-                sscf->ext_session_cache.memcache_host.data = value[i].data + total_len - len - 1;
+                sscf->ext_session_cache.memcache_host.data = value[i].data + total_len - len;
 
                 ngx_log_error_core(NGX_LOG_DEBUG, cf->log, 0,
-                               "memcache_host parsed as %V",
+                               "memcache_host parsed as %V (%d)",
-                               &sscf->ext_session_cache.memcache_host);
+                               &sscf->ext_session_cache.memcache_host, len);
+
+                /* Skip over ':' */
+                total_len++;
             }
 
             if (value[i].len > total_len) {