-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
now compiles in nvcc 10.2 #73
Conversation
What the heck...? Not sure why/how this got closed... |
Oh~ it's because it's trying to merge into the |
Whoops, on it in a bit! My apologies! |
@mpark OK, it's master now. |
@gridley the changes seem much bigger than it was before. seems like there may have been formatting applied or something? |
OK, so, maybe now this is ready once tests run. |
Okay, I've fixed |
I am trying to confirm this fixes my issue as well, but have troubles since the HPC machine (x86) this was found with changed (broke) its software environment recently and I cannot reproduce the original issue on other machines yet (tried on power). Trying to setup another x86 machine/environment today... |
Ok, I was now able to spin up another env that can reproduce the problem I reported. Sorry for the delay that this caused. As a side note: I reported the NVCC compiler frontend issue in #70 to Nvidia too and it will be fixed in the next CUDA release as well (latest today: NVCC 10.2.89). |
Summary: Fixes: #33203 PR based on mpark/variant#73 Verified locally on CUDA10.2.89 and 10.1.243 Thanks ngimel for the hint and gridley for the initial fix in the variant repo! :) Pull Request resolved: #33230 Differential Revision: D19858083 Pulled By: ngimel fbshipit-source-id: b9438084f5688712c6aa6b17813c68ccde237bbb
…33230) Summary: Fixes: pytorch#33203 PR based on mpark/variant#73 Verified locally on CUDA10.2.89 and 10.1.243 Thanks ngimel for the hint and gridley for the initial fix in the variant repo! :) Pull Request resolved: pytorch#33230 Differential Revision: D19858083 Pulled By: ngimel fbshipit-source-id: b9438084f5688712c6aa6b17813c68ccde237bbb
So, using some xtensor stuff which uses variant.hpp, I was trying to unable to compile stuff with NVCC 10.2 (latest version), and encountered some parsing error in nvcc that is described in this issue and this PR. It seems that part of the issue lies in xtensor-stack's xtl library and also this variant.hpp header file.
This PR just slightly changes an expression in variant.hpp so that the nvcc parser doesn't screw up. I think the code written here is valid beforehand, it's just that nvcc chokes on the parameter pack expansion somewhere.
The error which is encountered before this change, when including variant.hpp is:
No clue why this happens, but the changes here fix it.