Use separate methods for stats.

mperham · Aug 8, 2017 · cd6f0e0 · cd6f0e0
1 parent 8ac6a0c
commit cd6f0e0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/lib/connection_pool.rb b/lib/connection_pool.rb
@@ -113,11 +113,12 @@ def shutdown(&block)
     @available.shutdown(&block)
   end
 
-  def stats
-    {
-      size: @available.max,
-      available: @available.length
-    }
+  def max_connection_count
+    @available.max
+  end
+
+  def available_connection_count
+    @available.length
   end
 
   private

diff --git a/test/test_connection_pool.rb b/test/test_connection_pool.rb
@@ -502,14 +502,15 @@ def test_wrapper_with_connection_pool
   def test_stats_without_active_connection
     pool = ConnectionPool.new(size: 2) { NetworkConnection.new }
 
-    assert_equal({ size: 2, available: 2 }, pool.stats)
+    assert_equal(2, pool.max_connection_count)
+    assert_equal(2, pool.available_connection_count)
   end
 
   def test_stats_with_active_connection
     pool = ConnectionPool.new(size: 2) { NetworkConnection.new }
 
     pool.with do
-      assert_equal({ size: 2, available: 1 }, pool.stats)
+      assert_equal(1, pool.available_connection_count)
     end
   end
 end