Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New SIAFs for webbpsf-data package #34

Closed
josePhoenix opened this issue Jan 15, 2015 · 6 comments
Closed

New SIAFs for webbpsf-data package #34

josePhoenix opened this issue Jan 15, 2015 · 6 comments
Assignees
Milestone

Comments

@josePhoenix
Copy link
Collaborator

Upon investigating the current public SIAFs, it appears the SIAF parsing code in jwxml.py now expects a slightly different format. As far as I know, WebbPSF doesn't use SIAFs in its calculations (yet!) but we should update them anyway. (That way when field dependence support lands, it'll require a code update but not [necessarily] a data update.)

@josePhoenix josePhoenix added this to the 0.3 milestone Jan 15, 2015
@mperrin
Copy link
Owner

mperrin commented Jan 15, 2015

We should ping Colin Cox on this. I believe he has already made the relevant updates in his version of the SIAF reading code.

  • Marshall

On Jan 15, 2015, at 2:42 PM, Joseph Long <notifications@github.commailto:notifications@github.com> wrote:

Upon investigating the current public SIAFs, it appears the SIAF parsing code in jwxml.py now expects a slightly different format. As far as I know, WebbPSF doesn't use SIAFs in its calculations (yet!) but we should update them anyway. (That way when field dependence support lands, it'll require a code update but not [necessarily] a data update.)


Reply to this email directly or view it on GitHubhttps://github.com//issues/34.

@josePhoenix
Copy link
Collaborator Author

I've got the new XML files from Colin; however, he warned me that he would be updating several of them in the near future. jwxml seems to be able to read them (but not the ones currently in webbpsf-data).

@mperrin
Copy link
Owner

mperrin commented Jan 15, 2015

Ah OK I misread the issue. I thought you were saying the code needed to be updated but you mean the data files. By all means yes let's go ahead and add the current ones now, and we can update again before the release if Colin makes another updated set.

@josePhoenix
Copy link
Collaborator Author

All right, I think that's up to you since I can't write to the folder. Per Colin, the updated files are in /itar/jwst/tel/share/SIAF_WG/Instruments/SIAFXML/XML/.

@mperrin
Copy link
Owner

mperrin commented Jan 21, 2015

I have updated the files in /grp/jwst/ote/webbpsf-data with Colin's latest SIAF XML files. (and my master source directory as well, so whenever I next generate a new zip file the updated XML will be included in that)

Reminder to myself:

  • Relocate master copy of webbpsf data to /itar/jwst/tel and set up shared permissions
  • Document build scripts for making the webbpsf data zip files
  • Ping Dean about the MIRI filter files.

@mperrin mperrin self-assigned this Feb 11, 2015
@mperrin
Copy link
Owner

mperrin commented Feb 13, 2015

Master files relocated. (Again there is not actually any ITAR content in them, this is just the path to use given the existing shared files area on that disk)

Zip file building scripts updated; new zip files made for this release. I had to bump the version number a bit since the filter files changed, so it's now 0.3.1. I am slightly dismayed to have different version number on the data file than on the release itself but I don't think it can be helped right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants