Improve robustness of setup.py in the absence of certain dependencies #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed broken links in Pysynphot installation instructions - Formatted the list of dependencies nicely - included a tl;dr quickstart at the top
mperrin
added a commit
that referenced
this pull request
Oct 14, 2014
Improve robustness of setup.py in the absence of certain dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three changes to improve installation for users who may not already have all the dependencies installed:
webbpsf--webbpsf/__init__.pyimports from POPPY, which will not (necessarily) be available when setup.py is run. (impandastare standard library modules used to add this functionality)numpytoinstall_requiresandsetup_requires. (Currently, one of the AstroPy helpers tries to import NumPy, so it's necessary insetup_requiresaccording to the documented meaning of that option. It's possible this won't be needed if the AstroPy helpers are changed not to have a hard dependency on NumPy at this point in the install.)