Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThinLens update to use explicit radius argument #25

Merged
merged 1 commit into from
Nov 20, 2014

Conversation

josePhoenix
Copy link
Collaborator

Note: this remains a work-in-progress. WebbPSF master does not work for the commit I based this branch at, so there's something else going on.

Per mperrin/poppy#15, poppy.ThinLens now requires a radius argument to be given explicitly.

Some of the corresponding changes are:

In WebbPSF:

  • JWInstrument gains a pupil_radius attribute from the poppy.FITSOpticalElement generated in _getOpticalSystem
  • NIRCam thin lenses gain a radius keyword argument where they are instantiated
  • the ThinLens created when defocus_waves is supplied as an option gains a radius keyword argument

In POPPY:

  • addPupil, addRotation, addImage, addDetector all return the element they add (allowing API users to retain a reference to any FITSOpticalElements or others created transparently from their arguments)

mperrin added a commit that referenced this pull request Nov 20, 2014
ThinLens update to use explicit radius argument
@mperrin mperrin merged commit f30323a into mperrin:master Nov 20, 2014
@mperrin
Copy link
Owner

mperrin commented Nov 20, 2014

Whoops, could you pull request also the related changes in poppy too?

@josePhoenix
Copy link
Collaborator Author

Alas, the required branch is currently only on my work computer. Will do tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants