ThinLens update to use explicit radius argument #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this remains a work-in-progress. WebbPSF
master
does not work for the commit I based this branch at, so there's something else going on.Per mperrin/poppy#15,
poppy.ThinLens
now requires aradius
argument to be given explicitly.Some of the corresponding changes are:
In WebbPSF:
JWInstrument
gains apupil_radius
attribute from thepoppy.FITSOpticalElement
generated in_getOpticalSystem
radius
keyword argument where they are instantiatedThinLens
created whendefocus_waves
is supplied as an option gains aradius
keyword argumentIn POPPY:
addPupil
,addRotation
,addImage
,addDetector
all return the element they add (allowing API users to retain a reference to any FITSOpticalElements or others created transparently from their arguments)