-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn users about missing data or using WFIRSTImager #49
Conversation
Warn users about missing data or using WFIRSTImager
Hmm, so I went ahead and merged this. But now I see that it has the side effect of suppressing the exception in whatever program or module is trying to import webbpsf. Wouldn't it be better to pass the exception up higher so that the program that just tried the import knows it cannot continue? I guess I don't understand entirely the motivation for calling traceback.print_exc() in this context instead of just letting the exception percolate upwards? Example:
Note that the import case in the try was successful, as indicated by the print OK. |
Oh, whoops. I noticed Christine didn't read the notice and gravitated straight to the traceback, so I figured I'd reorder them. But, that has the unintended consequence you identified! Better fix that. On Feb 19, 2015, at 6:03 PM, Marshall Perrin notifications@github.com wrote:
|
Also, apparently GitHub emails are arriving delayed by an hour.
|
Last two changes pre-release: add disclaimer to WFIRST classes, improve user experience in the absence of WEBBPSF_DATA cc @mperrin @cslocum