Issue #9 Decode later, to avoid decoding in the middle of utf8 sequence

[davedoesdev]

And to make sure we only split on \r and \n (Unicode splitlines splits on a
number of other characters which is not in the SSE spec)

@mpetazzoni I tested on my own private project with Python 2.7 and 3.5.

This project could do with its own unit tests.

[mpetazzoni]

Thanks! Could the same problem happen with chunk.splitlines(True) when reading chunks from the event source in _read() ?

[davedoesdev]

No because in _read, the data is a byte string and according to https://docs.python.org/3/library/stdtypes.html#bytes.splitlines and https://docs.python.org/2/library/stdtypes.html#str.splitlines it breaks "at ASCII line boundaries".

Further, I think I'm right in saying UTF-8 of >=2 bytes can't include ASCII newline or carriage return (the MSB of all bytes will be 1).

[davedoesdev]

@mpetazzoni what do you think?

[davedoesdev]

OK to merge?

[mpetazzoni]

Sorry for the delay. I don't think you understood my previous comment. Lines 47-48:

for chunk in self._event_source:
  for line in chunk.splitlines(True):

I think it's possible here for chunk to be of type unicode depending on the event_source that was provided to the SSEClient. In this case, splitlines() would exhibit the same incorrect behavior.

[davedoesdev]

I guess it depends what stream means in this comment:

        The event source is expected to provide a stream() generator method and
        a close() method.

Maybe rewrite the comment?

        The event source is expected to provide a binary stream generator method and
        a close() method.

(using terminology from https://docs.python.org/3/library/io.html#binary-i-o)