Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #174 from henkel/fix-byte-array-to-hex-string
Fix byteArrayToHexString and add tests
- Loading branch information
Showing
7 changed files
with
124 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /** | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * <p/> | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p/> | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.turn.ttorrent.common; | ||
|
|
||
| public class Utils { | ||
|
|
||
| private final static char[] HEX_SYMBOLS = "0123456789ABCDEF".toCharArray(); | ||
|
|
||
| private Utils() { | ||
| } | ||
|
|
||
| /** | ||
| * Convert a byte string to a string containing the hexadecimal | ||
| * representation of the original data. | ||
| * | ||
| * @param bytes The byte array to convert. | ||
| * @see <a href="http://stackoverflow.com/questions/332079">http://stackoverflow.com/questions/332079/a> | ||
| */ | ||
| public static String bytesToHex(byte[] bytes) { | ||
| char[] hexChars = new char[bytes.length * 2]; | ||
| for (int j = 0; j < bytes.length; j++) { | ||
| int v = bytes[j] & 0xFF; | ||
| hexChars[j * 2] = HEX_SYMBOLS[v >>> 4]; | ||
| hexChars[j * 2 + 1] = HEX_SYMBOLS[v & 0x0F]; | ||
| } | ||
| return new String(hexChars); | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 70 additions & 0 deletions
70
core/src/test/java/com/turn/ttorrent/common/UtilsTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| /** | ||
| * Copyright (C) 2016 Philipp Henkel | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.turn.ttorrent.common; | ||
|
|
||
| import org.testng.annotations.Test; | ||
|
|
||
| import static org.testng.AssertJUnit.assertEquals; | ||
|
|
||
|
|
||
| public class UtilsTest { | ||
|
|
||
| @Test(expectedExceptions = NullPointerException.class) | ||
| public void testBytesToHexWithNull() { | ||
| Utils.bytesToHex(null); | ||
| } | ||
|
|
||
| @Test | ||
| public void testBytesToHexWithEmptyByteArray() { | ||
| assertEquals("", Utils.bytesToHex(new byte[0])); | ||
| } | ||
|
|
||
| @Test | ||
| public void testBytesToHexWithSingleByte() { | ||
| assertEquals("BC", Utils.bytesToHex(new byte[]{ | ||
| (byte) 0xBC | ||
| })); | ||
| } | ||
|
|
||
| @Test | ||
| public void testBytesToHexWithZeroByte() { | ||
| assertEquals("00", Utils.bytesToHex(new byte[1])); | ||
| } | ||
|
|
||
| @Test | ||
| public void testBytesToHexWithLeadingZero() { | ||
| assertEquals("0053FF", Utils.bytesToHex(new byte[]{ | ||
| (byte) 0x00, (byte) 0x53, (byte) 0xFF | ||
| })); | ||
| } | ||
|
|
||
| @Test | ||
| public void testBytesToHexTrailingZero() { | ||
| assertEquals("AA004500", Utils.bytesToHex(new byte[]{ | ||
| (byte) 0xAA, (byte) 0x00, (byte) 0x45, (byte) 0x00 | ||
| })); | ||
| } | ||
|
|
||
| @Test | ||
| public void testBytesToHexAllSymbols() { | ||
| assertEquals("0123456789ABCDEF", Utils.bytesToHex(new byte[]{ | ||
| (byte) 0x01, (byte) 0x23, (byte) 0x45, (byte) 0x67, | ||
| (byte) 0x89, (byte) 0xAB, (byte) 0xCD, (byte) 0xEF | ||
| })); | ||
| } | ||
|
|
||
| } |