Fix byteArrayToHexString and add tests #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 12, 2016
|
Thanks. What's up with the merge commit though? Could you fix the PR to only contain the change of Thanks! |
The old implementation of byteArrayToHexString drops the byte array’s leading zeros.
philipphenkel
force-pushed
the
fix-byte-array-to-hex-string
branch
from
468de74
to
4471694
Compare
|
I removed the merge commit that slipped into the pull request. |
mpetazzoni
added a commit
that referenced
this pull request
Mar 14, 2016
Fix byteArrayToHexString and add tests
|
Thanks; merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation of byteArrayToHexString drops the byte array’s
leading zeros.