Change FileCollectionStorage to not write 0 bytes to the next file at the end #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpetazzoni
added a commit
that referenced
this pull request
Nov 26, 2013
Change FileCollectionStorage to not write 0 bytes to the next file at the end
|
It took me a while to correctly understand what you were talking about. Not an easy topic to explain. But it looks fine. Thanks! |
Dead-off
added a commit
to JetBrains/ttorrent-lib
that referenced
this pull request
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently at the end of writing to a file it is likely that the offset+length will be equal to the next file offset. Usually while selecting files once we get to a file that is greater than our current offset+length we break out of the loop. I would consider the next file that has offset+length equal to the offset to be outside of the range that we should be writing to, so we should also break out for equals to.