Support default_escape=>'none' #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 19, 2013 15:40
The docs and codes show that default_escape accepts only upper case values, but this is in conflict that is made to the reference to accepting the that values that "escape" accepts. escapes documents accepting lower-case values instead.
This parallels what is accepted by 'escape'. As we are transitioning to escape by default, we have one method that sets a default of escape = none, and one that sets a default of escape = 'html'. In our case, we need to override a a setting of default_escape='html' with a default_escape='none', but this is currently not possible.
It refers to accepting the options that 'escape' does, but the escape docs show lowercase values, while default_escape checks for uppercase values. (Either should do). Also, 'escape' documents 'none' as a valid option, but 'default_escape' did not accept it.
mpeters
added a commit
that referenced
this pull request
Jun 25, 2013
Support default_escape=>'none'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For symmetry with escape, default_escape should also support 'none' as a valid value.
It's useful in a system like ours, where we have 'default_escape=>"html" set, but then need to override that in another method to set it back to 'none'.