Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support default_escape=>'none' #5

Merged
merged 3 commits into from
Jun 25, 2013
Merged

Support default_escape=>'none' #5

merged 3 commits into from
Jun 25, 2013

Commits on Jun 19, 2013

  1. Add test that shows default_escape accepts lower-case values. 

    The docs and codes show that default_escape accepts only upper case
values, but this is in conflict that is made to the reference to
accepting the that values that "escape" accepts. escapes documents
accepting lower-case values instead.
    Mark Stosberg committed Jun 19, 2013
    Configuration menu
    Copy the full SHA
    a4cc7ce View commit details
    Browse the repository at this point in the history

  2. Add test for default_escape => 'none' 

    This parallels what is accepted by 'escape'.

As we are transitioning to escape by default, we have one method that
sets a default of escape = none, and one that sets a default of escape = 'html'.

In our case, we need to override a a setting of default_escape='html'
with a default_escape='none', but this is currently not possible.
    Mark Stosberg committed Jun 19, 2013
    Configuration menu
    Copy the full SHA
    e1d299a View commit details
    Browse the repository at this point in the history

  3. Update default_escape implementation to follow the docs. 

    It refers to accepting the options that 'escape' does, but the escape
docs show lowercase values, while default_escape checks for uppercase
values. (Either should do).

Also, 'escape' documents 'none' as a valid option, but 'default_escape'
did not accept it.
    Mark Stosberg committed Jun 19, 2013
    Configuration menu
    Copy the full SHA
    caa07b2 View commit details
    Browse the repository at this point in the history