New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where custom preview would occupy space #84

Merged

mpiannucci merged 1 commit into mpiannucci:main from wkirby:bugfix/custom-preview-occupies-space

Jun 18, 2023

Contributor

wkirby commented Jun 18, 2023

Fixes the issue noted in #46:

Also I noticed bug with preview: it doesn't appear on screen but it takes space. Maybe you know how to fix this behaviour?

By positioning absolute we remove the custom preview view from the flow, which correctly informs the renderer not to take into account its size.


          Fix issue where custom preview would occupy space on screen even thou…

28107ec

…gh it was not rendered

mpiannucci approved these changes

View reviewed changes

Owner

mpiannucci left a comment

Awesome thank you for the contribution!

mpiannucci merged commit 1b15ac3 into mpiannucci:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment