-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more fields in JSON output #84
Conversation
…tion that we used. The change adds more fields to JSON output: zip_code, time_zone, region_name, region_code, metro_code(US only)
The output with new fields looks as follow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please expand the TestJSONHandlers
test to include a response with all these new fields. You can do this by setting the fields in the structs returned by the testDb
functions.
Tests were added |
Thanks! |
we are migrating from deprecated freegeoip, but echoip is missing information that we used. The change adds more fields to JSON output: zip_code, time_zone, region_name, region_code, metro_code(US only)
echoip output
freegeoip output