Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigurationFactoryBase - should allow loading custom configuration #312

Closed
mpostol opened this issue Jul 30, 2018 · 0 comments
Closed

ConfigurationFactoryBase - should allow loading custom configuration #312

mpostol opened this issue Jul 30, 2018 · 0 comments
Assignees
@mpostol
Labels
enhancement In progress
Milestone
Factory Simulator

Comments

@mpostol
Copy link
Owner

mpostol commented Jul 30, 2018

Describe the bug

The class must be generics and allow to load any type derived from ConfigurationData.
It requires modification of IConfigurationFactory.

ConfigurationFactoryBase must expose current configuration by an additional property.
@mpostol mpostol added the Bug Bug in the code. label Jul 30, 2018
@mpostol mpostol added this to the Factory Simulator milestone Jul 30, 2018
@mpostol mpostol self-assigned this Jul 30, 2018
@mpostol mpostol added enhancement In progress and removed Bug Bug in the code. labels Aug 1, 2018
mpostol added a commit that referenced this issue Aug 1, 2018
@mpostol
ConfigurationFactoryBase - should allow loading custom configuration #…
6261664 
…312

- The Configuration/Networking/ConfigurationFactoryBase.cs i s generic
- added default configuration loaded to promote reusability.
- UT 👍

- Next step: improve YT to provide some examples how to load a custom configuration file.
@mpostol mpostol closed this as completed in 0b0d2d1 Aug 3, 2018
mpostol added a commit that referenced this issue Aug 3, 2018
@mpostol
Merge pull request #313 from mpostol/400
02844af 
PR addressing: ConfigurationFactoryBase - should allow loading custom configuration #312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpostol mpostol

Labels
enhancement In progress
Projects
None yet
Milestone
Factory Simulator
Development

No branches or pull requests
1 participant
@mpostol