Add support for tagging AutoScaling Groups #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thank you for contribution |
|
Awesome, thanks @mpostument! I'll add tagging for EBS volumes over the next few days, stay tuned. For a little context, I plan to use awstaghelper for easy onboarding of my leanercloud.com AWS cost optimization tools which heavily rely on resource tagging for ASGs and EBS. Thanks for this wonderful little tool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main difference from the other resources is ASG tags can be propagated to instances.
For that I added a boolean flag automatically appended to the tag value,
|Propagate=true|falseThis is currently expected also when creating the values from a brand new CSV file, but I'm considering to make it a default to "true". What's your take on that?