Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the config file format with human-friendly JSON, and also adds code to seamlessly convert old configs to JSON if detected.
rationale
As the recent API key overload made clear (issue #551), users being able to edit the config themselves is an important feature (modifying the configured default API key is not really feasible by hand, as one user remarked).
The config is currently stored as a pickled binary file, which is not user-friendly.
Pickled binary storage is not necessary for any reasonable disk-space reasons. The difference in the old config style vs json is on the order of tens of bytes, as can be seen:
Signed-off-by: dt-rush nickp@balena.io