crash when typing da command

[sbutcher]

using ubuntu 12.04, version v0.01.40

da 17
Traceback (most recent call last):
File "/usr/local/bin/mpsyt", line 2954, in
main()
File "/usr/local/bin/mpsyt", line 2924, in main
if matchfunction(k, v, userinput):
File "/usr/local/bin/mpsyt", line 2836, in matchfunction
globals()funcname
File "/usr/local/bin/mpsyt", line 2256, in download
filename = _make_fname(song, None, av=av)
File "/usr/local/bin/mpsyt", line 1604, in _make_fname
extension = song.urls[key]['ext']
KeyError: 'ext'

[np1]

Thanks for reporting, there is no audio-only stream available for the video you are selecting. I will add code to handle this and display a message to the user.

[np1]

Hi again, can you tell me what steps you took to produce this error? I am having a hard time finding a video without audio streams (although I know there are some). Thanks.

[sbutcher]

Seems to be most of the ones i try..

Item Title Length
1 Lali Puna: Move On 03:32
2 Lali Puna-Together in Electric Dreams 04:36
3 Lali Puna Faking the Books 04:02
4 Lali Puna - Remember 03:45
5 Lali Puna - 603 05:11
6 Don't Think - Lali Puna 03:57
7 Lali Puna - Left Handed 03:45
8 Lali Puna: That Day 03:33
9 Lali Puna - Contratempo 04:27
10 Lali Puna & Bomb The Bass - Clear Cut (Original Mix) 05:26
11 Lali Puna - Grin And Bear 04:42
12 Lali Puna - Move On ( Baths remix ) 04:19
13 Scary World Theory - Lali Puna 04:45
14 lali puna nin com pop 04:58
15 Lali Puna - Call 1-800 FEAR 03:25
16 Lali Puna - Faking the Book 04:01
17 Lali Puna - Our Inventions 04:21
18 lali puna - i like rain (jean paul sartre experience cover) 04:42
19 Lali Puna-It's Not the Worst I've Looked 04:28

Search results for lali puna

da 18
Traceback (most recent call last):
File "/usr/local/bin/mpsyt", line 2954, in
main()
File "/usr/local/bin/mpsyt", line 2924, in main
if matchfunction(k, v, userinput):
File "/usr/local/bin/mpsyt", line 2836, in matchfunction
globals()funcname
File "/usr/local/bin/mpsyt", line 2256, in download
filename = _make_fname(song, None, av=av)
File "/usr/local/bin/mpsyt", line 1604, in _make_fname
extension = song.urls[key]['ext']
KeyError: 'ext'

Item Title Length
1 Tigermilk - Belle and Sebastian (Full album) 41:42
2 Get Me Away From Here, I'm Dying - Belle & Sebastian 03:27
3 The boy with the arab strap 05:10
4 Belle & Sebastian - I Want The World To Stop 04:56
5 Belle and Sebastian - Lazy Line Painter Jane 05:53
6 BELLE AND SEBASTIAN - I'M A CUCKOO 04:00
7 Belle and Sebastian - If You're Feeling Sinister - Pitchfork C 58:53
8 Belle and Sebastian: If She Wants Me 05:06
9 Belle and Sebastian - Dirty Dream #2 04:19
10 Belle et Sebastien 03:16
11 Belle & Sebastian Play 'I Want The World To Stop' At NME Award 04:58
12 Belle and Sebastian - Another Sunny Day 04:05
13 Belle and Sebastian - Wrapped Up In Books 03:43
14 Belle & Sebastian Piazza, New York Catcher 03:02
15 Belle and Sebastian - Another Sunny Day [Live At The BBC] 05:09
16 Belle & Sebastian On Scottish Independence At The NME Awards 01:41
17 Belle and Sebastian - The Fox in the Snow 04:01
18 Belle and Sebastian - Waiting for the moon to rise 03:06
19 Seeing Other People - Belle & Sebastian 03:51

da 2
Downloaded /home/sbutcher/Downloads/mps/Get Me Away From Here, I'm Dying - Belle & Sebastian.ogg

da 3
Traceback (most recent call last):
File "/usr/local/bin/mpsyt", line 2954, in
main()
File "/usr/local/bin/mpsyt", line 2924, in main
if matchfunction(k, v, userinput):
File "/usr/local/bin/mpsyt", line 2836, in matchfunction
globals()funcname
File "/usr/local/bin/mpsyt", line 2256, in download
filename = _make_fname(song, None, av=av)
File "/usr/local/bin/mpsyt", line 1604, in _make_fname
extension = song.urls[key]['ext']
KeyError: 'ext'

[np1]

Ok, I was wrong with my assumption that there is no audio available. I get the same issue with these items when mplayer is selected is the player. I set it to reject m4a streams for mplayer playback a while ago but in the process must have broken the downloads for m4a. I will fix it soon, in the meantime, does it help if you do:

set player mpv
then search again
then da <number>

[sbutcher]

thanks - i can confirm that after doing set player mpv, da does
download .m4a file, (even with mpv not available on the system)

On 12 March 2014 14:24, nagev notifications@github.com wrote:

Ok, I was wrong with my assumption that there is no audio available. I get
the same issue with these items when mplayer is selected is the player. I
set it to reject m4a streams for mplayer playback a while ago but in the
process must have broken the downloads for m4a. I will fix it soon, in the
meantime, does it help if you do:

set player mpv
then search again
then da

Reply to this email directly or view it on GitHubhttps://github.com/np1/mps-youtube/issues/52#issuecomment-37413797
.

[np1]

Hi, this has been fixed in the develop branch (https://github.com/np1/mps-youtube/commit/7ce65b7222faea23de600dfe07294f43ecada5db). It should be released sometime in the next few days.

In the meantime you can use the workaround above or use the d <number> command.

[np1]

This fix has just been released in v0.01.41. Please re-open the issue if you still have the problem after upgrading. Thanks.