Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changing window title a configurable option #498

Merged
merged 1 commit into from Mar 6, 2017

Conversation

ardrabczyk
Copy link
Contributor

@ardrabczyk ardrabczyk commented Jun 17, 2016

I have plenty of these in my ~/.fluxbox/keys:

Mod4 x :exec wmctrl -a uxterm || uxterm
Mod4 e :exec wmctrl -a emacs@ || emacs
(...)

When I press Mod4-x fluxbox moves focus to an existing window titled
`uxterm' or it starts a new instance of uxterm if such window does not
exist. When mpsyt changes its window title automatically it breaks
this workflow. I have added a new config option called set_title
which enables/disables automatic changing of window title. It is set
to True by default for backward compatibility.

@ids1024
Copy link
Contributor

ids1024 commented Jun 18, 2016

I think you should use WM_CLASS to identify uxterm instances, instead of the title. You can use the xprop command to find the value of this for a window, and it looks like it can be used in wmctrl with the -x argument.

So, try using wmctrl -x -a UXTerm.

@ardrabczyk
Copy link
Contributor Author

ardrabczyk commented Jun 18, 2016

On Fri, Jun 17, 2016 at 05:46:36PM -0700, Ian D. Scott wrote:

I think you should use WM_CLASS to identify uxterm instances, instead of the
title. You can use the xprop command to find the value of this for a window,
and it looks like it can be used in wmctrl with the -x argument.

Good idea, it works like charm. I have never thought about that,
thanks.

Now this patch is much less important but I think it's still valid.
Would you like to merge it or should I close it?

@ids1024
Copy link
Contributor

ids1024 commented Jun 18, 2016

I think the PR should be closed, unless there is another reason to want this. Using WM_CLASS is the "correct" way to handle this. It is best to avoid adding too many configuration options to mpsyt.

@ardrabczyk ardrabczyk closed this Jun 18, 2016
ardrabczyk added a commit to ardrabczyk/dotfiles that referenced this pull request Jun 22, 2016
@ids1024 ids1024 reopened this Mar 6, 2017
@ids1024 ids1024 merged commit a63c376 into mps-youtube:develop Mar 6, 2017
@ardrabczyk ardrabczyk deleted the title-mod-merge branch January 23, 2018 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants