Remember volume across multiple songs #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommysolsen
force-pushed
the
repeat_volume_fix
branch
from
e5c4707
to
bb3f4a5
Compare
|
This is probably a good idea.
Not really; nor would there be a generic way to set the volume. |
|
On my setup, mplayer would remember volume by itself.
It might be too "hacky", but we could potentially use windows built in volume mixer to get/set the volume, and just bypass the in client volume selector altogether, but it would be pretty hard to reliably have the same functionality on Linux, and I wouldn't know about OS X. |
tommysolsen
changed the title
ids1024
reviewed
Nov 17, 2017
mps_youtube/player.py
Outdated
| if softrepeat: | ||
| util.list_update("--loop-file", args) | ||
|
|
||
| elif "vlc" in config.PLAYER.get: | ||
| util.list_update("--play-and-exit", args) | ||
|
|
||
| print("args: " + str(config.PLAYER.get) + str(args) + str(stream['url'])) |
There was a problem hiding this comment.
There probably shouldn't be a print here.
Signed-off-by: Tommy Stigen Olsen <tommysolsen@gmail.com>
Volume control for mplayer Signed-off-by: Tommy Stigen Olsen <tommysolsen@gmail.com>
tommysolsen
force-pushed
the
repeat_volume_fix
branch
from
2ff4fbc
to
1b483d2
Compare
Signed-off-by: Tommy Stigen Olsen <tommysolsen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured we should find a more consistent way of dealing with volume changes across different songs.
Since we use the volume when we draw the player, I've started storing that in a global variable and
use that value to set the player volume between songs.
I've only tested and implemented this for
mpvand will implement this formplayeras well.Improvements & Testing
What other things should we do to make this a robust feature? Hopefully without adding much complexity for the user. There are some questions that I would like to raise and discuss.
If anyone has some ideas regarding how this functionality should work feel free to raise them as well.