Background playback improvements #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to use delete[] instead of delete. |
xyzz
reviewed
Feb 23, 2018
| dimension, dimension, AV_PIX_FMT_RGB32, | ||
| SWS_BICUBIC, NULL, NULL, NULL); | ||
| if (!ctx) | ||
| return NULL; |
There was a problem hiding this comment.
You're leaking new_data here. Probably better to replace with std::vector or similar so that RAII can be utilized.
xyzz
reviewed
Feb 23, 2018
app/src/main/jni/thumbnail.cpp
Outdated
| ALOGV("cropped w:%u h:%u\n", new_w, new_h); | ||
|
|
||
| std::vector<uint32_t> new_data; | ||
| new_data.reserve(new_w * new_h); |
There was a problem hiding this comment.
You can't use "new" vector members after you call reserve, you need to do resize, or just pass the size as argument to the constructor.
xyzz
reviewed
Feb 23, 2018
app/src/main/jni/thumbnail.cpp
Outdated
| std::vector<uint8_t> scaled; | ||
| scaled.reserve(dimension * dst_stride); | ||
| uint8_t *src_p[] = { (uint8_t*) new_data.data() }, *dst_p[] = { scaled.data() }; | ||
| sws_scale(ctx, src_p, &src_stride, 0, new_h, dst_p, &dst_stride); |
There was a problem hiding this comment.
All arrays you pass to sws_scale have to be 4 elements, it's a bug/undocumented in ffmpeg, so make sure src/dst/stride have 4 elements.
xyzz
reviewed
Feb 23, 2018
app/src/main/jni/thumbnail.cpp
Outdated
| std::vector<uint32_t> new_data; | ||
| new_data.reserve(new_w * new_h); | ||
| for (int y = 0; y < new_h; y++) { | ||
| for (int x = 0; x < new_w; x++) { |
There was a problem hiding this comment.
can the inner loop be replaced with memcpy?
sfan5
force-pushed
the
sfan5/bgplay_improvements
branch
from
6b6e71e
to
dd9374d
Compare
|
Merged as 6a7cd9e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please squash when merging
implements #102