Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpv.conf editing #108

Merged
merged 3 commits into from Apr 5, 2018
Merged

mpv.conf editing #108

merged 3 commits into from Apr 5, 2018

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Mar 7, 2018

this covers quite many feature requests at once, since this allows full control over mpv behaviours
e.g.:

  • fuzzy subtitle matching
  • custom subtitle codepage
  • save-position-on-quit
  • playback speed (to some degree)

(also adds a nice dialog with mpv-android version and mpv --version output)

@jeeb
Copy link
Member

jeeb commented Apr 5, 2018

Thanks for improving the commits. I have briefly tested this and it looked good. While the version-getting is just crazy, it seems to work and get more stuff than the properties (and as you have said on IRC, the logging receival can be useful somewhere else, too).

The difference to the version code-wise that I tested is as follows:

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index b2f6b45..68e1967 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -76,7 +76,7 @@
    <string name="pref_advanced_version">Version information</string>

    <string name="pref_advanced_mpvconf">Edit mpv.conf</string>
    <string name="pref_advanced_mpvconf_message">You can directly edit mpv\'s config here.\n\nImportant: mpv-android will overwrite some settings, so don\'t try to set e.g. \"dscale\" here.\nGenerally this applies to all settings that have a [-"native"-]{+\"native\"+} equivalent in the settings menu.</string>


    <!-- Strings indirectly related to Settings -->

Thus LGTM, no reason to keep this thing out.

@jeeb jeeb merged commit c8b6e12 into master Apr 5, 2018
@jeeb jeeb deleted the sfan5/mpvconf branch April 5, 2018 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants