Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio preferences with audio delay #113

Closed
wants to merge 2 commits into from

Conversation

junaru
Copy link

@junaru junaru commented Mar 25, 2018

Allows user to set audio-delay via the settings menu.
Main reason for implementing this was to have a way to compensate for sound delay on bluetooth headset when watching video with hardware decoding enabled.

<string name="pref_header_audio">Audio</string>

<string name="pref_audio_delay_title">Audio delay</string>
<string name="pref_audio_delay_summary">Usefull to compensate for out of sync audio.</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful*

@sfan5 sfan5 added the feature label Mar 25, 2018
@sfan5
Copy link
Member

sfan5 commented Apr 8, 2018

Since this can also be done by editing mpv.conf, I think this PR would provide more value if it used a slider or similar for easier tuning.

@junaru
Copy link
Author

junaru commented Apr 10, 2018

Indeed slider would look nicer but we would lose the ability to fine tune the setting.
If I'm not mistaken most players do audio delay in 10ms increments and for example my Bluetooth headphones introduce about 730ms of it.
So slider like control would have several issues:

  1. A need for 'reasonable' hard coded interval and that alone will probably ruin someones day.
  2. IMHO 'reasonable' would be [-3000ms:+3000ms], given 10ms increments that's 600 distinct values that you have to fit on a slider that would probably be more frustrating to use than the current edit box.
  3. A number picker like widget could have a bigger interval but user would still need to scroll through all the 10ms increments.

This is a fringe feature that not many would probably use to begin with and since mpv.conf editing was merged no hard feelings would be had if this was rejected altogether.

I'd personally like it to stay as number input.

@sfan5
Copy link
Member

sfan5 commented Sep 22, 2018

closed in favour of editing mpv.conf

@sfan5 sfan5 closed this Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants