Update dependency libraries and make main.cpp build with clang #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not handling all values is an error in clang, GCC seems to be more lenient with these things.
We already pumped up the default with the NDK compilation, so might as well pump it here as well.
jeeb
force-pushed
the
jeeb/fixup_clang
branch
from
f27717b
to
f8b86ba
Compare
jdek
approved these changes
Sep 18, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now builds with clang if you specify
NDK_TOOLCHAIN_VERSION=clangAlso bumps the mindSdkVersion to 21.