Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPVActivity: Add pref to extend video in the cutout area #296

Closed
wants to merge 1 commit into from

Conversation

philipl
Copy link
Contributor

@philipl philipl commented Aug 26, 2020

Many newer Android devices feature a notch or hole-punch camera, and by
default, Android will size landscape windows so that they don't extend
into the cutout area. For video playback, it is common to support
displaying the video over the entire screen, regardless of the cutout,
so let's add that option.

I've defaulted this to off, but maybe it should be on.

Many newer Android devices feature a notch or hole-punch camera, and by
default, Android will size landscape windows so that they don't extend
into the cutout area. For video playback, it is common to support
displaying the video over the entire screen, regardless of the cutout,
so let's add that option.

I've defaulted this to on as most people want to use all their screen.
@philipl
Copy link
Contributor Author

philipl commented Aug 27, 2020

Updated

  • do not assume API level
  • moved pref to General
  • defaulted to on.

@sfan5 sfan5 added the feature label Aug 27, 2020
@sfan5
Copy link
Member

sfan5 commented Aug 28, 2020

Merged 1a8505c

@sfan5 sfan5 closed this Aug 28, 2020
@ghost
Copy link

ghost commented Apr 25, 2022

This appears to not work on Android 12, Pixel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants