Skip to content

Commit

Permalink
ytdl: Error out with http_dash_segments
Browse files Browse the repository at this point in the history 
Unsupported for now.
  • Loading branch information
@wiiaboo
wiiaboo authored and wm4 committed Jul 30, 2016
1 parent 546f747 commit 5bcb22b
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions player/lua/ytdl_hook.lua
View file
Expand Up @@ -222,6 +222,10 @@ mp.add_hook("on_load", 10, function ()

-- DASH?
if not (json["requested_formats"] == nil) then
if (json["requested_formats"][1].protocol == "http_dash_segments") then
msg.error("MPEG-Dash Segments unsupported, add [protocol!=http_dash_segments] to your ytdl-format.")
return
end

-- video url
streamurl = json["requested_formats"][1].url
Expand Down

6 comments on commit 5bcb22b

@Isopod
Copy link

@Isopod Isopod commented on 5bcb22b Aug 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was DASH support removed? It worked fine before. Now I only get this error message. How exactly is this an improvement?

Before: Works out of the box, get highest quality
Now: Doesn't work out of the box, have to change config, don't get highest quality

I Just downgraded mpv and it works fine again. Please revert this.

If you you have to hardcode this, at least adjust the default ytdl-format so everything works out of the box. Don't tell a user to edit their config if they never changed it in the first place (i.e. they don't even have a config file). Or better yet, only adjust the default ytdl-format and remove this error message completely. That way I can at least choose to use DASH at my own risk, even if you as the developers consider it too buggy or whatever. Cause I was quite happy with how it worked before.

@Kagami
Copy link
Contributor

@Kagami Kagami commented on 5bcb22b Sep 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mpv v0.18.0

Works without any issues: mpv ytdl://TJfA79eJiGY --ytdl-format='bestvideo+bestaudio'

mpv v0.20.0

Doesn't work: mpv ytdl://TJfA79eJiGY --ytdl-format='bestvideo+bestaudio' (MPEG-Dash Segments unsupported)
Works: mpv ytdl://TJfA79eJiGY --ytdl-format='bestvideo'
Works: mpv ytdl://TJfA79eJiGY --ytdl-format='bestaudio'
Doesn't work: mpv ytdl://TJfA79eJiGY --ytdl-format='bestvideo[protocol!=http_dash_segments]+bestaudio[protocol!=http_dash_segments]' (requested format not available)

Could you please explain what are the correct options to play the exact same formats with the latest mpv?

@Isopod
Copy link

@Isopod Isopod commented on 5bcb22b Sep 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have to use best[protocol!=http_dash_segments]. But this doesn't give you the same quality as bestvideo+bestaudio, for example you might only get 720p instead of 1080p and less efficient codecs with more compression artifacts. This is exactly what I was complaining about. The silly part is that bestvideo+bestaudio works in the old version. This is why I'm still on v0.18.0.

@Hund
Copy link

@Hund Hund commented on 5bcb22b Oct 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having this issue on a few to many videos now. I'm using Newsbeuter (for the YouTube subscriptions) with mpv and youtube-dl on my HTPC with limited access to a keyboard. So it's really annoying to have to download the video with youtube-dl and then play it with mpv.

I really hope this gets resolved in a sane way soon enough. :)

@Kagami
Copy link
Contributor

@Kagami Kagami commented on 5bcb22b Oct 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wiiaboo could you elaborate rationality of this change?
Have you seen multi-segmented DASH at youtube? In my experience (and I watch a lot of youtube videos with mpv in bestvideo+bestaudio mode) everything were played fine. And proposed [protocol!=http_dash_segments] format doesn't make any difference for some videos anyway (see above). It failbacks to 720p while it was possible to play 1080p before.

@wiiaboo
Copy link
Member Author

@wiiaboo wiiaboo commented on 5bcb22b Oct 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that it doesn't fallback and errors anyway. This just says why it errors.

Please sign in to comment.