Skip to content

Commit

Permalink
vo_gpu_next: use pl_dispatch_info_move to avoid useless data copy
Browse files Browse the repository at this point in the history
Instead copy the data on-demand when VOCTRL_PERFORMANCE_DATA is
requested.
  • Loading branch information
kasper93 authored and haasn committed Jul 23, 2023
1 parent 5f58ec1 commit 8516c4e
Showing 1 changed file with 46 additions and 21 deletions.
67 changes: 46 additions & 21 deletions video/out/vo_gpu_next.c
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@ struct user_lut {
struct pl_custom_lut *lut;
};

struct frame_info {
int count;
struct pl_dispatch_info info[VO_PASS_PERF_MAX];
};

struct priv {
struct mp_log *log;
struct mpv_global *global;
Expand Down Expand Up @@ -146,7 +151,8 @@ struct priv {
int num_user_hooks;

// Performance data of last frame
struct voctrl_performance_data perf;
struct frame_info perf_fresh;
struct frame_info perf_redraw;

bool delayed_peak;
bool inter_preserve;
Expand Down Expand Up @@ -750,28 +756,15 @@ static void info_callback(void *priv, const struct pl_render_info *info)
if (info->index >= VO_PASS_PERF_MAX)
return; // silently ignore clipped passes, whatever

struct mp_frame_perf *frame;
struct frame_info *frame;
switch (info->stage) {
case PL_RENDER_STAGE_FRAME: frame = &p->perf.fresh; break;
case PL_RENDER_STAGE_BLEND: frame = &p->perf.redraw; break;
case PL_RENDER_STAGE_FRAME: frame = &p->perf_fresh; break;
case PL_RENDER_STAGE_BLEND: frame = &p->perf_redraw; break;
default: abort();
}

int index = info->index;
struct mp_pass_perf *perf = &frame->perf[index];
const struct pl_dispatch_info *pass = info->pass;
static_assert(VO_PERF_SAMPLE_COUNT >= MP_ARRAY_SIZE(pass->samples), "");
assert(pass->num_samples <= MP_ARRAY_SIZE(pass->samples));

perf->count = MPMIN(pass->num_samples, VO_PERF_SAMPLE_COUNT);
memcpy(perf->samples, pass->samples, perf->count * sizeof(pass->samples[0]));
perf->last = pass->last;
perf->peak = pass->peak;
perf->avg = pass->average;

strncpy(frame->desc[index], pass->shader->description, sizeof(frame->desc[index]) - 1);
frame->desc[index][sizeof(frame->desc[index]) - 1] = '\0';
frame->count = index + 1;
frame->count = info->index + 1;
pl_dispatch_info_move(&frame->info[info->index], info->pass);
}

static void update_options(struct vo *vo)
Expand Down Expand Up @@ -1299,6 +1292,30 @@ static void video_screenshot(struct vo *vo, struct voctrl_screenshot *args)
pl_tex_destroy(gpu, &fbo);
}

static inline void copy_frame_info_to_mp(struct frame_info *pl,
struct mp_frame_perf *mp) {
static_assert(MP_ARRAY_SIZE(pl->info) == MP_ARRAY_SIZE(mp->perf), "");
assert(pl->count <= VO_PASS_PERF_MAX);
mp->count = MPMIN(pl->count, VO_PASS_PERF_MAX);

for (int i = 0; i < mp->count; ++i) {
const struct pl_dispatch_info *pass = &pl->info[i];

static_assert(VO_PERF_SAMPLE_COUNT >= MP_ARRAY_SIZE(pass->samples), "");
assert(pass->num_samples <= MP_ARRAY_SIZE(pass->samples));

struct mp_pass_perf *perf = &mp->perf[i];
perf->count = MPMIN(pass->num_samples, VO_PERF_SAMPLE_COUNT);
memcpy(perf->samples, pass->samples, perf->count * sizeof(pass->samples[0]));
perf->last = pass->last;
perf->peak = pass->peak;
perf->avg = pass->average;

strncpy(mp->desc[i], pass->shader->description, sizeof(mp->desc[i]) - 1);
mp->desc[i][sizeof(mp->desc[i]) - 1] = '\0';
}
}

static int control(struct vo *vo, uint32_t request, void *data)
{
struct priv *p = vo->priv;
Expand Down Expand Up @@ -1340,9 +1357,12 @@ static int control(struct vo *vo, uint32_t request, void *data)
p->want_reset = true;
return VO_TRUE;

case VOCTRL_PERFORMANCE_DATA:
*(struct voctrl_performance_data *) data = p->perf;
case VOCTRL_PERFORMANCE_DATA: {
struct voctrl_performance_data *perf = data;
copy_frame_info_to_mp(&p->perf_fresh, &perf->fresh);
copy_frame_info_to_mp(&p->perf_redraw, &perf->redraw);
return true;
}

case VOCTRL_SCREENSHOT:
video_screenshot(vo, data);
Expand Down Expand Up @@ -1448,6 +1468,11 @@ static void uninit(struct vo *vo)

pl_renderer_destroy(&p->rr);

for (int i = 0; i < VO_PASS_PERF_MAX; ++i) {
pl_shader_info_deref(&p->perf_fresh.info[i].shader);
pl_shader_info_deref(&p->perf_redraw.info[i].shader);
}

p->ra_ctx = NULL;
p->pllog = NULL;
p->gpu = NULL;
Expand Down

0 comments on commit 8516c4e

Please sign in to comment.