Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
vo_gpu: add better gamut clipping option
See https://code.videolan.org/videolan/libplacebo/-/commit/d63eeb1ecc204 Enabled by default because I think it looks better. YMMV.
- Loading branch information
Showing
4 changed files
with
21 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc24a43
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is on by default, does that mean it will always clip? Or will it automatically see how wide the gamut is and act accordingly? More concisely, do I need to set
--gamut-clipping=no
when applying--target-prim=bt.2020
?dc24a43
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This option never introduces clipping. It's about clipping in a smarter way, in cases that would previously clip badly.
Right now it always runs when gamut mapping is performed. In theory we could make it only run when the gamut is being reduced, that's what the libplacebo commit mentioned does. But the performance impact from a non-divergent branch is negligible so I don't think it's a big deal.
Only if you want to save a few nanoseconds.
dc24a43
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So left enabled, it won't affect the color in an HDR wide gamut environment?