Skip to content

Commit

Permalink
Stop supporting GNOME
Browse files Browse the repository at this point in the history 
On GNOME, you're supposed to use native GNOME software anyway.
  • Loading branch information
wm4 committed Jul 7, 2020
1 parent 8fbc4b1 commit fe791de
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions video/out/vo.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,14 @@ static struct vo *vo_create(bool probing, struct mpv_global *global,

struct vo *init_best_video_out(struct mpv_global *global, struct vo_extra *ex)
{
const char *xdg_current_desktop = getenv("XDG_CURRENT_DESKTOP");
if (xdg_current_desktop && strstr(xdg_current_desktop, "GNOME")) {
struct mp_log *log = mp_log_new(NULL, global->log, "vo");
mp_fatal(log, "This player does not support GNOME.\n");
talloc_free(log);
return NULL;
}

struct mp_vo_opts *opts = mp_get_config_group(NULL, global, &vo_sub_opts);
struct m_obj_settings *vo_list = opts->video_driver_list;
struct vo *vo = NULL;
Expand Down

9 comments on commit fe791de

@thegreatestminer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@overmighty
Copy link

@overmighty overmighty commented on fe791de Jul 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely Dangerously based.

@legendofmiracles
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMFAO

@elkowar
Copy link

@elkowar elkowar commented on fe791de Jul 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, noone likes gnome anyways

@periish
Copy link

@periish periish commented on fe791de Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yes!

@periish
Copy link

@periish periish commented on fe791de Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LETS FUCKING GOOOOOOOOOOOOO

@legendofmiracles
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we lock out gnome users?

@legendofmiracles
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is your account hacked?

@haasn
Copy link
Member

@haasn haasn commented on fe791de Jul 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with you refusing to provide support for GNOME users, but in terms of the actual software I think this should at the very least be made a non-fatal warning. There's a big difference between "not providing support" and "artificially restricting the ability to run software". This is basically DRM, and I'm not okay with that.

Ideally, this is a matter that should concern the issue tracker alone, not the software.

Edit: I see it's already been reverted. But I guess I might as well still chime in with my opinion for the record.

Please sign in to comment.