Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vo_gpu-next: vapoursynth filter seems could not receive dolbyvision's metadata #10438

Open
hooke007 opened this issue Jul 23, 2022 · 5 comments

Comments

@hooke007
Copy link
Contributor

Important Information

Provide following Information:

Reproduction steps

# mpv.conf
vo=gpu-next
  1. run mpv.exe and play a dv file, and then activate any vapoursynth filter.

  2. vf toggle vapoursynth="~~/test0.vpy"

# test0.vpy
video_in.set_output()

Expected behavior

correct color

Actual behavior

mpv-shot0001

Log file

mpv-test.log

@hooke007 hooke007 changed the title vapoursynth filter seems to not be received dolbyvision's metadata vo_gpu-next: vapoursynth filter seems could not receive dolbyvision's metadata Jul 23, 2022
@quietvoid
Copy link
Contributor

The side data doesn't propagate through the vapoursynth vf.
Not sure if it would be easily doable, but from my perspective it isn't.

@chainikdn
Copy link
Contributor

Not 100% sure about the patch cause there's strange color blinking sometimes (not always, just in some scenes) when the filter increases frame rate. Maybe I'm missing something important here o_O

@hooke007
Copy link
Contributor Author

hooke007 commented Nov 17, 2022

#10390 (comment)

when the filter increases frame rate

Probably there is the loss of luminace info in the extra frames created by vs.

@chainikdn
Copy link
Contributor

it doesn't happen on every inserted frame
more like some frames occasionally lose this DoVi data

@Durden-T
Copy link

same for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants