Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vf_vapoursynth: copy side data (Dolby Vision, etc) from the source frame #12593

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chainikdn
Copy link
Contributor

@chainikdn chainikdn commented Oct 7, 2023

Fixing #10438.
Continue from 10884, now copying everything and using existing function.

2nd commit is about passing DoVi data into Vapoursynth, so the script could take care in some way (which is required for any interpolation filter, for example).

@chainikdn
Copy link
Contributor Author

any chance?

@hooke007
Copy link
Contributor

Better to manually @sfan5 @Dudemanguy .
Have no idea why it was ignored before releasing v0.37.0.

{
VSMap *map = p->vsapi->getFramePropsRW(frame);
if (!map)
return -1;
p->vsapi->propSetInt(map, "_DurationNum", dur_num, 0);
p->vsapi->propSetInt(map, "_DurationDen", dur_den, 0);
p->vsapi->propSetInt(map, "__frameno", frameno, 0);
if(img->dovi && img->dovi->size)
p->vsapi->propSetData(map,"_DoVi", img->dovi->data, img->dovi->size, 0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code style

video/filter/vf_vapoursynth.c Show resolved Hide resolved
@kasper93
Copy link
Contributor

FYI, After merge of #13458 img->dovi no longer holds AVDOVIMetadata and instead pl_dovi_metadata. You can get old AVDOVIMetadata from img->ff_side_data or add buffer ref directly it as before.

@sfan5 sfan5 added priority:stale Issue is too old and is unclear if it's even applicable anymore priority:stalled and removed priority:stale Issue is too old and is unclear if it's even applicable anymore labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants