Meson sets global config path incorrectly

[hurzl]

... even with --keep-open=no, both on "Enter" or ">" keys.
Expected: 0.34 closed the program when I pressed "Enter" on single file or on last file on playlist.

FreeBSD 13.1
mpv 0.35.0 Copyright © 2000-2022 mpv/MPlayer/mplayer2 projects
built on Thu Nov 17 04:25:08 2022

[CounterPillow]

Where is your --log-file? Do not ignore the issue template please.

[hurzl]

mpvlog.txt

[sfan5]

[ 1.281][d][cplayer] Run command: playlist-next, flags=73, args=[flags="weak"]

       playlist-next <flags>
              Go to the next entry on the playlist.

              First argument:

              weak (default)
                     If the last file on the playlist is currently played, do nothing.

              force  Terminate playback if there are no more files on the playlist.

This is working as intended and the keybindings for this have not changed in years.

[hurzl]

So before 0.35 it wasn't?

In /usr/local/etc/mpv/input.conf I have
ENTER playlist_next force
Apparently this was obeyed by 0.34, but not by 0.35 (without --no-config of course)

In the 0.35 log file I see
[ 0.006][d][global] config path: 'input.conf' -/-> 'etc/mpv/input.conf'
where the absolute path is missing
It works when I put that line into ~/.config/mpv/input.conf

[sfan5]

A look into config.h reveals that meson.build sets the config path incorrectly:

~/mpv $ grep CONFDIR build/config.h 
#define MPV_CONFDIR "etc/mpv"

for comparison (waf):

/tmp/mpv $ grep CONFDIR build/config.h
#define MPV_CONFDIR "/usr/local/etc/mpv"

[Dudemanguy]

Oh so this is actually different defaults that I guess favors Linux distros over BSDs. Meson uses the sysconfdir option which will default to etc + /mpv. If the prefix is set to /usr, then this path becomes /etc/mpv. Apparently on waf, the default is always just the prefix + /etc/mpv.

[sfan5]

My example is with prefix set to /usr/local, the path set by meson is just plain wrong and not even absolute.

[Dudemanguy]

Apparently it magically works if you just join the paths of prefix and sysconfdir and it doesn't result in /usr/etc for the -Dprefix=/usr case.

[brad0]

I happened to notice this commit. For OpenBSD we use prefix=/usr/local and sysconfdir=/etc. For WAF we were using..

CONFIGURE_ARGS =	--confloaddir=${SYSCONFDIR}/mpv \
			--confdir=${LOCALBASE}/share/examples/mpv

which is /etc/mpv and /usr/local/share/examples/mpv.

[Dudemanguy]

If you were already explicitly setting the path anyway, it will work the same way before and after this commit. This just makes the default not a wrong path in some cases.

[brad0]

If you were already explicitly setting the path anyway, it will work the same way before and after this commit. This just makes the default not a wrong path in some cases.

Well we just converted over to using Meson. But with that commit it appears as if the path is now hardcoded so if we use prefix=/usr/local and sysconf=/etc that the conf path is /usr/local/etc/mpv instead of /etc/mpv. I don't mind whichever is the default. Just as long as there is a way of overriding the path.

[Dudemanguy]

It's not hardcoded. I don't know about how the ports work but essentially you'll want to pass: meson setup build -Dprefix=/usr/local -Dsysconfdir=/etc As long as you pass an absolute path to sysconfdir, it'll override the prefix part of it.