Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are still problems when MPV opens some streaming media #11700

Closed
Lonely233233 opened this issue May 19, 2023 · 25 comments · Fixed by #11718
Closed

There are still problems when MPV opens some streaming media #11700

Lonely233233 opened this issue May 19, 2023 · 25 comments · Fixed by #11718

Comments

@Lonely233233
Copy link

Open the link still exists in #11674 (comment) The issue raised here"https://play-tx-recpub.douyucdn2.cn/live/super_live -252140rz7aIq14cx--20230519024114/playlist.m3u8?tlink=64674f81&tplay=6467dc21&exper=0&nlimit=5&us=1000000000000000000000000001501&sign=22e5fe 0f 86ef6d857fb7558a178c5be9&u=434690231&d=1000000000000000000000000001501&ct=web&vid=37585308&pt=2&cdn=tx"

MPV version 230518

Uosc.log

@Lonely233233 Lonely233233 changed the title MPV打开部分流连接仍然存在部分问题 There are still problems when MPV opens some streaming media May 19, 2023
@Traneptora
Copy link
Member

Geo-restricted URL, cannot reproduce

@Lonely233233
Copy link
Author

image

@Traneptora
Copy link
Member

Unrelated to #11674

@Lonely233233
Copy link
Author

Unrelated to #11674

The 230430 version plays these M3U8 links are not clips, can it be repaired?

@kasper93
Copy link
Contributor

It doesn't present itself as HLS playlist.

[   0.284][v][ffmpeg] Mime-type: 'application/x-mpeg'

We can strip url params and match extension in this case, but for HTTP resources it really should be matched by Content-Type.

How common are mislabeled streams like that?

@Lonely233233
Copy link
Author

It doesn't present itself as HLS playlist.

[   0.284][v][ffmpeg] Mime-type: 'application/x-mpeg'

We can strip url params and match extension in this case, but for HTTP resources it really should be matched by Content-Type.

How common are mislabeled streams like that?

Can it be solved?

@sfan5
Copy link
Member

sfan5 commented May 19, 2023

None of this would be an issue if ffmpeg didn't decide to tighten the hls demuxer requirements for no good reason.
Most people don't care if the RFC is followed to the letter, they just want their media to work. FFmpeg is also usually more liberal in what kind of files it accepts (because in reality specs often get ignored) so not sure why the hls demuxer has to be an exception.

@kasper93
Copy link
Contributor

I feel reluctant to match file extension in HTTP resources URI. The Content-Type exist for the reason and there is really no concept of "file extension" as URI can differ completely form what is actually provided based on HTTP headers. That said, probably we need to support those mislabeled streams too.

So probably stripping all url parames before av_match_ext and hoping there is extension is the way.

@zouhair
Copy link

zouhair commented May 25, 2023

This makes mpv mostly useless to me :(

kasper93 added a commit to kasper93/mpv that referenced this issue May 25, 2023
Unfortunately Content-Type matching seems to be not enough as there are
mistagged streams. Try to match extension and pass-through URL.

Fixes mpv-player#11700
@Lonely233233
Copy link
Author

This makes mpv mostly useless to me :(

I agree with your opinion

sfan5 pushed a commit that referenced this issue May 30, 2023
Unfortunately Content-Type matching seems to be not enough as there are
mistagged streams. Try to match extension and pass-through URL.

Fixes #11700
@kasper93
Copy link
Contributor

Should work better now after recent merge. Let us know if there are still issues with some streams.

@Lonely233233
Copy link
Author

Should work better now after recent merge. Let us know if there are still issues with some streams.

Ok, has the previous problem been fixed?

@Lonely233233
Copy link
Author

230531 has been fixed, there is no problem for the time being

@Lonely233233
Copy link
Author

Should work better now after recent merge. Let us know if there are still issues with some streams.

Youku.com video streamed to MPV through YT-DLP is a video fragment, but it is complete when capturing M3U8 through developer tools. Should I report this problem to YT-DLP?

@kasper93
Copy link
Contributor

If you want to post mpv log we can suggest next steps. Since Youku is region locked, I cannot really test it.

@Lonely233233
Copy link
Author

Lonely233233 commented Jun 1, 2023

Uosc.log

Help to see if I should report to YT-DLP

But 230430 opens YOUKU.com video through YT-DLP but it is complete

Uosc 230430.log

@kasper93
Copy link
Contributor

kasper93 commented Jun 1, 2023

I see the issue, I will fix that when I have a second.

@Lonely233233
Copy link
Author

I see the issue, I will fix that when I have a second.

"youku" m3u8 streaming link fixed?

@kasper93
Copy link
Contributor

kasper93 commented Jun 28, 2023

I've sent the patch for FFmpeg three weeks ago https://ffmpeg.org/pipermail/ffmpeg-devel/2023-June/310332.html but it has not been merged.

@Lonely233233
Copy link
Author

I've sent the patch for FFmpeg three weeks ago https://ffmpeg.org/pipermail/ffmpeg-devel/2023-June/310332.html but it has not been merged.

uncomfortable

@kasper93
Copy link
Contributor

It has been merged now as FFmpeg/FFmpeg@0cd2e7d Next mpv builds should work correctly for your case.

@Lonely233233
Copy link
Author

It has been merged now as FFmpeg/FFmpeg@0cd2e7d Next mpv builds should work correctly for your case.

thank

@Lonely233233
Copy link
Author

It has been merged now as FFmpeg/FFmpeg@0cd2e7d Next mpv builds should work correctly for your case.

fixed thanks

@Lonely233233
Copy link
Author

It has been merged now as FFmpeg/FFmpeg@0cd2e7d Next mpv builds should work correctly for your case.

perfect

image

dyphire pushed a commit to dyphire/mpv that referenced this issue Jul 8, 2023
Unfortunately Content-Type matching seems to be not enough as there are
mistagged streams. Try to match extension and pass-through URL.

Fixes mpv-player#11700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants