New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video output often freezes on 60fps VP9 video #3758
Comments
Happens to me on that clip as well, although I don't have any problems when e.g. playing 60 fps youtube videos (which I request in VP9 format) Also, it always happens in exactly the same positions for me (i.e. exactly around 10:12 or so), which is pretty suspect. |
Can you reproduce it with e.g. For me, it seems to happen always a few seconds after starting playback. After running for a while, however, it seems to play fine. |
Nothing special about 10:10, it can happen much earlier as well. I see this on SXZ3qWAvbVs as well (I downloaded it with |
Hmm, I'm getting it too now for youtube videos. Must be a recent thing. I can try bisecting it. |
|
I think this has been going on for a long time, because it also happened with mpv 0.14.0-1build1 on xenial. |
@ivan That must have been a different bug. mpv 0.14.0 is basically from the stone age, so it wouldn't surprise me. |
Plays perfect to me, except in 12:47-12:48, but that happens with ffplay too.
Xubuntu 16.04.1 LTS x86_64
cat /usr/share/X11/xorg.conf.d/xorg.conf
I've been testing with an i915, with SNA acceleration see many glitches using OpenGL (glx*, mpv, pcsxr, mupen64plus, etc). But with UXA works "well"... |
I can also confirm reverting the commit fixes freezes with 60 fps VP9 on Windows 10 x64 with GTX 1060. |
I tried again with a new compilation and still works the same. The commit 17733bd makes no difference to me.
|
The logic seems to have been flipped around for some reason. (Judging by the comment, the intent was to force a redraw when using blend-subtitles so that a changed subtitle would still register on a redrawn frame. Although I doubt the legitimacy of this intent, this fix simply makes the logic match the comment) The second check that was in gl_video_upload_image was removed because it was self-defeating: by duplicating the check from is_new, it skipped the upload entirely even in cases where it was necessary (e.g. due to is_new being set to true by this branch, or by the output FBO being invalid). The skip logic is supposed to be handled in gl_video_render_frame, not gl_video_upload_image. Fixes mpv-player#3758 and mpv-player#3764.
Probably fixed... |
mpv version and platform
xubuntu 16.04.1 with Intel video, no compositor, no
TearFree
or any other unusual options, 4K displayReproduction steps
Note that it will freeze at many other locations in the video, but it is not always reproducible at the exact same locations.
Expected behavior
mpv frame skips where needed, but does not stop video output permanently
Actual behavior
video output frozen permanently (until leaving and re-entering fullscreen, or sending other events)
Log file
Nothing special seems to happen when the video output freezes.
http://sprunge.us/WhQi
Sample files
https://ludios.org/tmp/WipEout%20HD%20-%20Supersonic%20in%201080p%2060FPS-uQqRIX1RMtE.webm
The text was updated successfully, but these errors were encountered: