Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vo_gpu-next: Compatibility with shaders #9390

Closed
hooke007 opened this issue Nov 3, 2021 · 4 comments
Closed

vo_gpu-next: Compatibility with shaders #9390

hooke007 opened this issue Nov 3, 2021 · 4 comments

Comments

@hooke007
Copy link
Contributor

hooke007 commented Nov 3, 2021

Important Information

Provide following Information:

  • mpv version
    a73e5cd

  • Windows Version
    win11 release

  • Source of the mpv binary
    built based on shinchiro

  • If known which version of mpv introduced the problem

  • Possible screenshot or video of visual glitches
    ravu-zoom-r3

Reproduction steps

open the video and apply any shader.

Expected behavior

No error or no crash.

Actual behavior

ravu-zoom -- error in the console
adaptive-sharpen , SSim -- crash
nnedi3-nns64-win8x4 -- the chroma plane is terrible while luma plane was stretched.

Also, once ravu caused the error firstly (as u can c in the picture), and then any shaders could not be actived at runtime.

Log file

ravu-zoom-r3.log
adaptive-sharpen.log

Sample files

ravu-zoom https://github.com/bjin/mpv-prescalers/blob/master/vulkan/compute/ravu-zoom-r3.hook
nnedi3 https://github.com/bjin/mpv-prescalers/blob/master/compute/nnedi3-nns64-win8x4.hook
adaptive and ssim https://gist.github.com/igv

@hooke007 hooke007 added the os:win label Nov 3, 2021
@haasn
Copy link
Member

haasn commented Nov 4, 2021

ravu-zoom -- error in the console

This one is a ravu bug. It uses the (undocumented) function LUT_POS which is not part of the mpv shader API. You can fix it by adding this to the shader:

#define LUT_POS(x, lut_size) mix(0.5 / (lut_size), 1.0 - 0.5 / (lut_size), (x))

@haasn
Copy link
Member

haasn commented Nov 4, 2021

adaptive-sharpen , SSim -- crash

Fixed the crash in haasn/libplacebo@08456a11b306ad

@haasn
Copy link
Member

haasn commented Nov 4, 2021

nnedi3-nns64-win8x4 -- the chroma plane is terrible while luma plane was stretched.s

Can you open a new issue for this? (And in future, one issue per different type of bug)

@hooke007
Copy link
Contributor Author

hooke007 commented Nov 4, 2021

Can you open a new issue for this?

#9395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants