Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vo_gpu_next: assertion failure when using lavfi-complex #9499

Closed
Dudemanguy opened this issue Nov 22, 2021 · 2 comments
Closed

vo_gpu_next: assertion failure when using lavfi-complex #9499

Dudemanguy opened this issue Nov 22, 2021 · 2 comments
Labels
os:linux vo:gpu-next

Comments

@Dudemanguy
Copy link
Member

Dudemanguy commented Nov 22, 2021 •
edited

Important Information

Provide following Information:

  • mpv version: 67c1ff8
  • libplacebo version: 8ea8f3aa
  • Window Manager and version: Sway 1.6.1 (but it also happens in xorg)
  • GPU driver and version: RX 550 using amdgpu with mesa's radv (21.3.0)

Reproduction steps

Open up an image and use lavfi-complex to combine it with itself. Ex:

mpv --no-config --vo=gpu-next --image-display-duration=inf --lavfi-complex='[vid1] [vid2] vstack [vo]' image.jpg --external-file=image.jpg

Expected behavior

The two images are vertically stacked.

Actual behavior

There's actually an assertion failure:

mpv: ../libplacebo/src/renderer.c:1790: pass_output_target: Assertion `image->color.primaries == img->color.primaries' failed.

The assertion error is new actually. Before that was added to libplacebo, what would happen is that images would have a weird red color over them like below (obviously these are supposed to be black/white manga pages).

2021-11-21-192938_grim

Log file

log file
backtrace
haasn added a commit that referenced this issue Nov 22, 2021
@haasn
vo_gpu_next: apply csp overrides for RGB/XYZ/YUV formats
2b2442e 
This is needed when the color system is not explicitly tagged, but
instead needs to be inferred by the VO.

Note that there exists the function mp_image_params_guess_csp for this
sort of stuff, but it contains a lot of baggage that I don't want to
replicate, in order to move as much of this logic into pl_renderer as
possible, and therefore also give it the best chance of knowing what
shortcuts it can and can't take.

Fixes the other half of #9499
@haasn
Copy link
Member

haasn commented Nov 22, 2021 •
edited

Btw, just for future reference, when posting gdb var dumps I would be immensely grateful if you set print pretty on first. (Or put it into ~/.gdbinit)

@Dudemanguy
Copy link
Member Author

I honestly didn't even know that option existed. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
os:linux vo:gpu-next
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haasn @Dudemanguy