meson: unbreak linux/input-event-codes.h detection in some cases #10871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's stopping this from being fixed in |
|
I've filed https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267784 |
|
Wouldn't waf have this same problem or is something different there? |
|
Looking at this one again. I'd be fine with |
jbeich
commented
Mar 7, 2023
|
what's the status here? freebsd still uses this patch and would be nice to upstream it. |
Dudemanguy
approved these changes
Jul 24, 2023
Dudemanguy
requested changes
Jul 24, 2023
|
@jbeich: just pinging you in case you don't see the comment. |
On DragonFly and FreeBSD native evdev headers are not not be used outside of base system. Linux-compatible headers are provided by evdev-proto package but require extra flags. As evdev-proto lacks pkg-config support use libwayland prefix as approximation. meson.build:974:0: ERROR: C header 'linux/input-event-codes.h' not usable
Dudemanguy
reviewed
Jul 24, 2023
|
Pushed as 3bdf702 (got rid of an extra newline). Sorry about all the delay on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found downstream. When disabling some Meson options
-I/usr/local/includemaybe disappear, breaking configure check.evdev-proto(a subset of linux-headers) which provides the header on some BSDs doesn't support pkg-config (lacks *.pc file), so use one of wayland libraries as approximate location for now.Note, using
dependenciesasinclude_directorieslooks even more hacky:include_directories: include_directories(dependency('wayland-client').get_variable(pkgconfig: 'includedir')))include_directories: include_directories(get_option('prefix') / 'include')https://mesonbuild.com/Reference-manual_returned_compiler.html#compilercheck_header