Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tests for ffmpeg 6.0 #11456

Merged
merged 2 commits into from Mar 14, 2023
Merged

update tests for ffmpeg 6.0 #11456

merged 2 commits into from Mar 14, 2023

Conversation

Dudemanguy
Copy link
Member

testing

@Dudemanguy
github/workflows: fix failure conditions
addf900 
It turns out that you actually have to add failure() to each condition
otherwise a default status check of success() is applied (thanks
github). Looks redundant but whatever. Thanks to @kasper93 for actually
reading the documentation.
@Dudemanguy
test: update format refs to ffmpeg 6
d524d21 
Major release means new formats and failing tests so just add the new
stuff to the ref again and bump the minimum libavutil version. The last
ffmpeg commit that added a new format and is the minimum required
version for these subset of tests is referenced below.

https://git.ffmpeg.org/gitweb/ffmpeg.git/commit/479747645f795b6f4f376578ea1556409f943c31
@Dudemanguy
Copy link
Member Author

Okay should be good now.

jeeb
jeeb approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@jeeb jeeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We will have to rework the pix_fmt tests later to not have one big reference file, but for now this should be fine.

@jeeb jeeb merged commit e172755 into mpv-player:master Mar 14, 2023
12 checks passed
@Dudemanguy Dudemanguy deleted the fix-tests-again branch March 14, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeeb jeeb jeeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dudemanguy @jeeb